Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs snippets test for Scarb >=2.8.1 #2742

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Fix docs snippets test for Scarb >=2.8.1 #2742

merged 3 commits into from
Dec 3, 2024
+26 −17

Conversation

ddoktorski
Copy link
Contributor

@ddoktorski ddoktorski commented Dec 2, 2024 •
edited
Loading

Introduced changes

  • Fix e2e::docs_snippets_validation::test_docs_snippets which failed in the last scheduled run
  • Replace changeable values: gas and execution resources with wildcard [..] in outputs validation

franciszekjob
franciszekjob reviewed Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please replace all occurrences of gas: ~<some_number> to gas: ~[..] in snippets outputs in *.md files? 🙏
Update: we modified function comparing output so gas and similar numerical values are replaced by [..] before comparison.

@ddoktorski ddoktorski added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit 771cf1d Dec 3, 2024
26 checks passed
@ddoktorski ddoktorski deleted the fix-test-docs-snippets branch December 3, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur cptartur approved these changes

@kkawula kkawula Awaiting requested review from kkawula kkawula is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddoktorski @cptartur @franciszekjob